-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loganalyzer_common_ignore regexs for config reload on broadcom #13316
Conversation
…atform These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore.
r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute.*" | ||
r, ".* ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute.*" | ||
r, ".* ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*" | ||
r, ".* ERR syncd\d*#syncd.*SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters.* failed with error Feature unavailable.*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@byu343 for the 5 lines above I understand they are caused by sonic-net/SONiC#1101 added by Nvidia. What I am not sure is the 3 lines below, Could you please clarify why you want to ignore them? What is the real root cause for those 3 lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable."
r, ". ERR syncd\d*#syncd.SAI_API_PORT:brcm_sai_get_port_stats. port fdr stats get failed with error Feature unavailable.*"
Above two lines are from broadcom SAI for reading FEC counters on certain ports not supporting them.
r, ".* ERR swss#portsyncd: :- readData: netlink reports an error=-33 on reading a netlink socket."
r, ". ERR systemd-udevd[\d*]:.* bcm0: Failed to get link config: No such device.*"
We only see occasional issues with them from our testing results. I should remove them from the this change
r, ".* ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*" | ||
r, ".* ERR syncd\d*#syncd.*SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters.* failed with error Feature unavailable.*" | ||
r, ".* ERR syncd\d*#syncd.*SAI_API_PORT:brcm_sai_get_port_stats.* port fdr stats get failed with error Feature unavailable.*" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@byu343 thank you for the update, but I still didn't find "port fdr stats get failed with error Feature unavailable" in our nightly test result. Probably, not related to sonic-net/SONiC#1101 as well. Can we remove it for now and add it back if we observe it in our nightly test and confirm that it's not image issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will create a separate PR for FEC counter error from broadcom SAI:
r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable."
r, ". ERR syncd\d*#syncd.SAI_API_PORT:brcm_sai_get_port_stats. port fdr stats get failed with error Feature unavailable.*"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@byu343 I think we have some miscommunication here:
ERR syncd\d#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.* should be included this PR, since it is caused by sonic-net/SONiC#1101, same with ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute..
But I suggest don't include ERR syncd\d#syncd.SAI_API_PORT:brcm_sai_get_port_stats. port fdr stats get failed with error Feature unavailable.* in this PR, because I didn't find any of it in our nightly test.
Do you have other concerns or any misunderstanding here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ZhaohuiS,
My understanding is that the error for _brcm_sai_read_fec_stat_err_counters is from reading the FEC counter and unrelated to the query hash-related capacities in sonic-net/SONiC#1101. But anyway, I could add it to this PR for the same reason of unblocking log checking.
"port fdr stats get failed with error Feature unavailable" We saw this a lot on 7260 t0-116. We could put this in another PR in case we will need it later.
1ae40cc
to
d927ddf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hi @yxieca @bingwang-ms for cherry pick to 202311 / 202405. |
…onic-net#13316) What is the motivation for this PR? These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore. These are from the change sonic-net/sonic-swss#2598. r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*" r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*" How did you do it?
Cherry-pick PR to 202311: #13442 |
…13316) What is the motivation for this PR? These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore. These are from the change sonic-net/sonic-swss#2598. r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*" r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*" How did you do it?
hi @bingwang-ms could you approve on 202405? |
1 similar comment
hi @bingwang-ms could you approve on 202405? |
…onic-net#13316) What is the motivation for this PR? These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore. These are from the change sonic-net/sonic-swss#2598. r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*" r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*" How did you do it?
Cherry-pick PR to 202405: #13558 |
…13316) What is the motivation for this PR? These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore. These are from the change sonic-net/sonic-swss#2598. r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*" r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*" How did you do it?
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore.
These are from the change sonic-net/sonic-swss#2598.
r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*"
r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*"
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation